[MERGE] Convert tests.blackbox.test_f* to use internals where appropriate

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alexander Belchenko wrote:
> Daniel Watkins пишет:
>> Attached is a fix for tests.blackbox.test_find_merge_base (the only 'f'
>> in need of attention).
> 
> bb:tweak
> 
> allow_pointless=True is pointless from technical POV, but it
> make things explicit and more readable, IMO.
> 
> Changes for the test itself look good, but I'd like to see imports cleaned up
> as well. E.g. in this way:
> 
> === modified file 'bzrlib/tests/blackbox/test_find_merge_base.py'
> --- bzrlib/tests/blackbox/test_find_merge_base.py       2007-06-27 19:13:50 +0000
> +++ bzrlib/tests/blackbox/test_find_merge_base.py       2007-08-13 19:49:45 +0000
> @@ -14,8 +14,9 @@
>  # You should have received a copy of the GNU General Public License
>  # along with this program; if not, write to the Free Software
>  # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
> +
> +import os
>  from bzrlib.tests.blackbox import ExternalBase
> -import os
> 
> 
>  class TestFindMergeBase(ExternalBase):


Well, that should actually be:

import os

from bzrlib.tests.blackbox import ExternalBase


You should have 1 blank line between the stdlib imports, and bzrlib imports.

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGwMESJdeBCYSNAAMRAhcgAJwPyWYcp5rRM/2Vai7ToKum0Q6RMACePg73
Zx+t4pfgZh3/JtN7uxBAvow=
=cCFm
-----END PGP SIGNATURE-----