[MERGE] Convert tests.blackbox.test_f* to use internals where appropriate
Alexander Belchenko
bialix at ukr.net
Mon Aug 13 20:51:58 BST 2007
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Daniel Watkins пишет:
> Attached is a fix for tests.blackbox.test_find_merge_base (the only 'f'
> in need of attention).
bb:tweak
allow_pointless=True is pointless from technical POV, but it
make things explicit and more readable, IMO.
Changes for the test itself look good, but I'd like to see imports cleaned up
as well. E.g. in this way:
=== modified file 'bzrlib/tests/blackbox/test_find_merge_base.py'
- --- bzrlib/tests/blackbox/test_find_merge_base.py 2007-06-27 19:13:50 +0000
+++ bzrlib/tests/blackbox/test_find_merge_base.py 2007-08-13 19:49:45 +0000
@@ -14,8 +14,9 @@
# You should have received a copy of the GNU General Public License
# along with this program; if not, write to the Free Software
# Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA
+
+import os
from bzrlib.tests.blackbox import ExternalBase
- -import os
class TestFindMergeBase(ExternalBase):
- --
[µ]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFGwLZezYr338mxwCURAi3XAKCEYxcfZ6iLGG6/u/2zv5oUsA9+DwCfZlwg
F7KpK+kOU+cSpOmeTdNxdv4=
=RhOH
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list