[MERGE] Send actually *sends* the merge directive

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alexander Belchenko wrote:
> Aaron Bentley ?8H5B:
>> Alexander Belchenko wrote:
>>> Aaron Bentley ?8H5B:
>>>> Here is a new patch that provides both Evolution and Thunderbird support.
>>> bb:resubmit
>>> Your patch does not work for me. Sorry.
>> Thanks for the report.  This one should work for you.
> 
> bb:resubmit
> 
> Now I got different exception.
> Before traceback is splashed my editor was opened and prompted me
> to describe a bundle.
> 
> E:\Bazaar\mydev\aaron>python bzr --no-plugins send --mail-to bialix at ukr.net
> Using saved location: file:///E:/Bazaar/mydev/bzr.dev/
> bzr: ERROR: socket.error: (10061, 'Connection refused')
> As I understand it's because I don't configure smtp_server in bazaar.conf.
> But anyway, I don't think that in this case windows users (who usually
> don't have smtp server in their localhost) should see such traceback.

I agree.  I think this is a bug in configuration handling; on Win32, we
should not assume a local SMTP server.

And even Ubuntu does not have an SMTP server by default, so we should
error cleanly if we incorrectly guess the smtp server.

This is not a bug in my code, however; it's in in
smtp_connection.send_email.

> BTW, is it possible to specify mail server that should work via SSL connection?
> My email provider (ukr.net) allows me to use smtp via SSL only.

I don't know.  TLS is supposed to be automatically detected.

> I think there is should be a way to look into windows registry to search
> thunderbird executable. There are some keys in registry that holds
> full path to thunderbird.exe. I'll try to investigate this and
> prepare a patch.
> Does full path to thunderbird.exe is enough for send command?

Yes, that should be all we need.

I suggest changing (Evolution|Thunderbird)_client_commands to
_get_client_commands(), and doing your registry lookup there.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGvIEc0F+nu1YWqI0RAh8tAJ4/FEOhm7P44EBr+ox0187hYvOVPACeLigm
xVLGe6rP9z9TfccfXymeSIk=
=Ek6X
-----END PGP SIGNATURE-----