[MERGE] internal glob expansion for all commands on win32 and for invocations from the test suite

Kuno Meyer kuno.meyer at gmx.ch
Wed Aug 8 23:19:02 BST 2007


On 08.08.2007 23:39, Aaron Bentley wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Kuno Meyer wrote:
>> On 08.08.2007 20:16, Aaron Bentley wrote:
>>> Aaron Bentley has voted resubmit.
>>> Status is now: Resubmit
>>> Comment:
>>> Doing this based on variable name is too magic for my taste.  I
>>> suggest we add a new marker that causes glob expansion to happen, and
>>> also imply that multiple arguments would be converted into a list.  If
>>> it was, say '#', we would change 'file*' to 'file#' everywhere it is
>>> used.
>> Done.
>>
>> In order to 'convince' ;-) plugin authors to switch their argument
>> types, I added a warning message if a command defines "file*" in the
>> takes_argument member. Otherwise, I fear, most of the plugins won't get
>> adapted.

Removed. I guess it wouldn't even be acceptable to print it in 
development versions (vs. released versions)?

> 
> I don't think we will be able to merge it with this warning intact.  I
> think you are underestimating the number of people who are not plugin
> authors who would be affected.
> 
>> Please note that (as I stated in my initial post) I never ran the test
>> suite under Linux, especially ("bzr selftest wildcard Win32Utils").
> 
> Yeah.  It breaks.  Log attached.

Hopefully corrected.

Kuno
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: internalglobexpand_v2.1.patch
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20070809/6ee3aa44/attachment-0001.diff 


More information about the bazaar mailing list