[MERGE] internal glob expansion for all commands on win32 and for invocations from the test suite
Aaron Bentley
aaron.bentley at utoronto.ca
Wed Aug 8 22:39:31 BST 2007
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Kuno Meyer wrote:
> On 08.08.2007 20:16, Aaron Bentley wrote:
>> Aaron Bentley has voted resubmit.
>> Status is now: Resubmit
>> Comment:
>> Doing this based on variable name is too magic for my taste. I
>> suggest we add a new marker that causes glob expansion to happen, and
>> also imply that multiple arguments would be converted into a list. If
>> it was, say '#', we would change 'file*' to 'file#' everywhere it is
>> used.
>
> Done.
>
> In order to 'convince' ;-) plugin authors to switch their argument
> types, I added a warning message if a command defines "file*" in the
> takes_argument member. Otherwise, I fear, most of the plugins won't get
> adapted.
I don't think we will be able to merge it with this warning intact. I
think you are underestimating the number of people who are not plugin
authors who would be affected.
> Please note that (as I stated in my initial post) I never ran the test
> suite under Linux, especially ("bzr selftest wildcard Win32Utils").
Yeah. It breaks. Log attached.
Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFGujgT0F+nu1YWqI0RAnd1AJ453l1/1Fk/EM4A1MWAPiJbCxZBHgCfXAqD
uUFbHjYZAdYZnOVZj8K+rcc=
=80jE
-----END PGP SIGNATURE-----
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: err
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20070808/d81c838a/attachment.diff
More information about the bazaar
mailing list