[MERGE] repository.reconcile_actions

[Martin Pool]

On 8/8/07, Robert Collins <robertc at robertcollins.net> wrote:
> On Tue, 2007-08-07 at 18:15 -0400, Aaron Bentley wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > Robert Collins wrote:
> > > Do we have self.testIsIrrelevant or an equivalent yet? This is not a
> > > skip, not an expected fail, not a missing feature.
> >
> > What's a skip?  I thought this was a skip.
>
> A skip is a test that cannot be run because of missing but optional
> support. E.g. writing to format 4 repositories are all skips - we can in
> principal implement a writer for that format and not skip the tests.
>
> In this case the reason we are not running the test is not due to a
> limitation in the class being tested, it because the test is irrelevant
> to that class.
>
> We currently 'return from tests' in many places where this is the case.

No, we don't have them yet.  I posted an rfc about having more test
results; when the flood of reviews lets up I will try to write it.  Or
someone else can.  Some kind person already implemented the --strict
part of it.

For the moment since we only have skip I would encourage people to
always use that, rather than returning early, when the test cannot be
run for whatever reason.  We can then very easily grep through and
replace them with the appropriate specific result when those classes
exist.  It is much harder to grep for or otherwise find cases where
the test returns early.


-- 
Martin