[MERGE] selftest fails if the committer name contains non-ASCII characters

[Lukáš Lalinský]

On St, 2007-08-01 at 15:04 -0400, Martin Pool wrote:
> Martin Pool has voted resubmit.
> Status is now: Resubmit
> Comment:
> Thanks for the patch, this does seem to be a test bug.
> 
> I guess you're seeing this because you have a non-ascii name yourself. 
> In general we don't want tests to pass for some people and fail for 
> others, so I think what we actually want to do is run all these tests 
> using a non-ascii committer.
> 
> +        output_encoding = osutils.get_terminal_encoding()
> 
> Also, we probably don't want the tests to depend on the encoding of the 
> person running the test.  So, rather, we should print most of them in 
> UTF-8, I think.
> 
> +    def get_fake_stdio(self, encoding_type=None):
> 
> Probably wants a docstring.  Actually, there's nothing about stdio in 
> this method, so it could just be called make_encoding_stringio().  I 
> think John had some thoughts about whether we should be doing this kind 
> of conversion in tests.
> 
> Also you should add a NEWS entry under 'Testing' and credit yourself 
> there.

I've renamed the method and changed the encoding to always use UTF-8. If
you think it would be better to use something like
tree.commit(committer='Lorem Ipsum <test at example.com>') in all affected
tests, I'll do it that way.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: bzr-log-test.diff
Type: text/x-patch
Size: 8242 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070807/595612e1/attachment.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: Toto je =?ISO-8859-1?Q?digit=E1lne?=
	=?ISO-8859-1?Q?_podp=EDsan=E1?= =?UTF-8?Q?_=C4=8Das=C5=A5?=
	=?ISO-8859-1?Q?_spr=E1vy?=
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070807/595612e1/attachment.pgp