[MERGE] selftest fails if the committer name contains non-ASCII characters

[Martin Pool]

Martin Pool has voted resubmit.
Status is now: Resubmit
Comment:
Thanks for the patch, this does seem to be a test bug.

I guess you're seeing this because you have a non-ascii name yourself. 
In general we don't want tests to pass for some people and fail for 
others, so I think what we actually want to do is run all these tests 
using a non-ascii committer.

+        output_encoding = osutils.get_terminal_encoding()

Also, we probably don't want the tests to depend on the encoding of the 
person running the test.  So, rather, we should print most of them in 
UTF-8, I think.

+    def get_fake_stdio(self, encoding_type=None):

Probably wants a docstring.  Actually, there's nothing about stdio in 
this method, so it could just be called make_encoding_stringio().  I 
think John had some thoughts about whether we should be doing this kind 
of conversion in tests.

Also you should add a NEWS entry under 'Testing' and credit yourself 
there.

For details, see: 
http://bundlebuggy.aaronbentley.com/request/%3C1185960872.6348.24.camel%40nemo%3E