[MERGE] Replace Repository.__eq__/__ne__ methods with Repository.is_same_repository
Andrew Bennetts
andrew at canonical.com
Tue Aug 7 08:00:20 BST 2007
Robert Collins wrote:
> On Tue, 2007-08-07 at 11:45 +1000, Andrew Bennetts wrote:
> !tweak
>
> >Andrew Bennetts wrote:
> > [...]
> > >
> > > In the meantime, I'll rework the patch to use a method other than __eq__.
> >
> > Here is that patch. It removes Repository.__eq__/__ne__, and instead adds
> > Repository.is_same_repository.
> >
> > I've taken care to document the possibility of false negatives in the docstring.
> > It doesn't make any claim about lock states.
>
> This is good. One thing - the tests for the new method should go in a
> new test script in repository_implementations.
I don't follow you — the tests for this method already are in
repository_implementations, and so get run for all repository formats.
-Andrew.
More information about the bazaar
mailing list