[MERGE] Replace Repository.__eq__/__ne__ methods with Repository.is_same_repository

Robert Collins robertc at robertcollins.net
Tue Aug 7 03:48:35 BST 2007


On Tue, 2007-08-07 at 11:45 +1000, Andrew Bennetts wrote:
!tweak

>Andrew Bennetts wrote:
> [...]
> > 
> > In the meantime, I'll rework the patch to use a method other than __eq__.
> 
> Here is that patch.  It removes Repository.__eq__/__ne__, and instead adds
> Repository.is_same_repository.
> 
> I've taken care to document the possibility of false negatives in the docstring.
> It doesn't make any claim about lock states.

This is good. One thing - the tests for the new method should go in a
new test script in repository_implementations.

Cheers,
Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070807/e6089a6b/attachment.pgp 


More information about the bazaar mailing list