0.18: Too verbose commit

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jari Aalto wrote:
> * Thu 2007-08-02 John Arbash Meinel <john AT arbash-meinel.com>
> * Message-Id: 46B1E501.7030709 AT arbash-meinel.com
>> Jari Aalto wrote:
>>
>>> Hi,
>>>
>>> After upgrading to 0.18, the commit is, ahem, way too verbose. It
>>> would be better if these messages appeared only with -v option.
>>>
>>> I'd normally expect clean and simple message:
>>>
>>>    $ bzr ci -m "- fixed ..."
>>>    Committed revision 1.
>>>    $
>> Also, I don't think you realize that there is a global '-q' option.
>> Which does have specific effect for 'commit'.
> 
> Hm, tried the -q, but it still prints messages to stderr. I would
> expect bzr to be completely silent with -q

You're right, I see the same thing.

It seems that '-q' doesn't disable the progress bar correctly.

In the older code, with dots you would just get more '.' messages, because each
step didn't change the progress message.

But Ian's changes make it print out Directory X/Y, etc. Which means that the
progress indicator changes, so it wants to print out a new summary line.

Attached is a patch which forces the DummyProgress object when we have the
global 'is_quiet' set.

It probably needs a test, but otherwise should be good. I did actually test
this, rather than just spouting off again about -q. Sorry I didn't research it
enough before. In the past, -q was fine for me (but that was because TTY cleans
up after itself and runs fast enough you don't see it)

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGsgQBJdeBCYSNAAMRAtUwAJ0ScDtX4ZfJPs3TLkMuAMzsGS3gXQCggw45
zL7o25rkbXqWp3g0IStb6qw=
=vlf+
-----END PGP SIGNATURE-----
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: quiet_progress.diff
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20070802/5faad7a9/attachment.diff