[MERGE] make run_bzr stricter about which keyword arguments it takes

Martin Pool mbp at canonical.com
Wed Aug 1 20:08:15 BST 2007


Martin Pool has voted approve.
Status is now: Approved
Comment:
+        if kwargs:
+            raise TypeError("run_bzr() got unexpected keyword arguments 
'%s'"
+                            % kwargs.keys())
+

I would generally write this as

    % (kwargs.keys(),)

just to avoid fmt problems if the function returns a tuple.  But it 
looks like .keys() is documented to return a list, so there's no 
specific problem here.

For details, see: 
http://bundlebuggy.aaronbentley.com/request/%3C46B0A94C.6000308%40canonical.com%3E



More information about the bazaar mailing list