[MERGE] InterTree.compare doesn't pass require_versioned on correctly

John Arbash Meinel john at arbash-meinel.com
Tue Jul 31 15:34:29 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Marius Kruger wrote:
> On 7/30/07, John Arbash Meinel <john at arbash-meinel.com> wrote:
>> John Arbash Meinel has voted approve.
>> Status is now: Semi-approved
>> Comment:
>> I'm not sure why you did:
>> -                   want_unversioned=False):
>> +                   require_versioned=False, want_unversioned=False):
>>
>> rather than:
>> -                   want_unversioned=False):
>> +                   want_unversioned=False, required_versioned=False):
>>
>> But if the other functions like this use the former, than it is fine.
> 
> yes ALL the other functions have it in this order,
> and I know I changed the method signature,
> but I thought that since it is a _internal
> function and it is only used once,
> that it is ok if I change it like I did.
> 

Yeah, I figured that was why. I just wanted to bring it up.

I'm 100% okay with it.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGr0h0JdeBCYSNAAMRAp55AJ4uEs5AfZJ+jrwoEyMeUJGEYTgzrACgixxo
YR0igKGYc+/ZWuDWWWEFdzA=
=qg2K
-----END PGP SIGNATURE-----



More information about the bazaar mailing list