[MERGE] InterTree.compare doesn't pass require_versioned on correctly

Marius Kruger amanic at gmail.com
Tue Jul 31 05:26:44 BST 2007


On 7/30/07, John Arbash Meinel <john at arbash-meinel.com> wrote:
> John Arbash Meinel has voted approve.
> Status is now: Semi-approved
> Comment:
> I'm not sure why you did:
> -                   want_unversioned=False):
> +                   require_versioned=False, want_unversioned=False):
>
> rather than:
> -                   want_unversioned=False):
> +                   want_unversioned=False, required_versioned=False):
>
> But if the other functions like this use the former, than it is fine.

yes ALL the other functions have it in this order,
and I know I changed the method signature,
but I thought that since it is a _internal
function and it is only used once,
that it is ok if I change it like I did.



More information about the bazaar mailing list