[MERGE] Remove a spurious call to 'get_master_branch()'

Martin Pool mbp at sourcefrog.net
Fri Jul 27 22:07:06 BST 2007


On 7/27/07, Aaron Bentley <aaron.bentley at utoronto.ca> wrote:
> Aaron Bentley has voted comment.
> Status is now: Semi-approved
> Comment:
> The master branch thing looks okay, but I have no idea what you're doing
> with the traceback.  This is a traceback of a non-failure?

Yes, it's to show why it was called.  I'm fine for it to be there, but
it should say "new connection caused by: " so it's clear it's not an
exception.

When doing this on locks I actually wanted a shortened traceback, with
just the consecutive function names on one line.  It's normally
obvious where the call was in the method.

-- 
Martin



More information about the bazaar mailing list