[MERGE][Take Five] Show the diff in the commit messages

Goffredo Baroncelli kreijack at tiscalinet.it
Thu Jul 26 23:45:07 BST 2007

On Thursday 26 July 2007, John Arbash Meinel wrote:
> John Arbash Meinel has voted +1 (conditional).
> Status is now: Conditionally approved
> Comment:
> But I'm more concerned with the API changes of having "make_commit_*" 
> return an 8-bit string instead of Unicode, and "edit_commit_*" take 
> 8-bit instead of Unicode.

Ok, I update my patch: the new api have the _encoded postfix. The old 
functions are provided as wrapper to the new one in order to save the 

> I know of at least 1 plugin that either is overriding edit_commit_* or 
> using it to fill out an auto-generated commit message.
> I'm not saying we can't do it, but at a minimum we need to be aware that 
> it is happening, and it should be documented in NEWS.
Also the NEWS file is updated.

> For details, see: 

gpg key@ keyserver.linux.it: Goffredo Baroncelli (ghigo) <kreijack at inwind.it>
Key fingerprint = CE3C 7E01 6782 30A3 5B87  87C0 BB86 505C 6B2A CFF9
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bzr-ci---show-diff.bundle.diff
Type: text/x-diff
Size: 31407 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070727/a0fca6fa/attachment-0001.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070727/a0fca6fa/attachment-0001.pgp 

More information about the bazaar mailing list