error during bzr add

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Alaa Salman wrote:
> I can also confirm this bug. However, i encountered it on windows.
> 
> The problem was the name of a directory containing some weird
> characters(by weird i mean non-ascii) So i think it was choking on it. I
> can provide the directory name if it would help.
> 
> Regards,
> Alaa Salman

I would be surprised to see this happen on Windows, since we go through their
Unicode api. (And you shouldn't be able to create files that it cannot
represent in UTF-16).

So I would certainly be interested in hearing about it.

I could see having problems with terminal encoding being able to display them.
But that means we have a bug in 'bzr add' that it fails if it tries to display
a filename it cannot represent. (It should be effectively using
path.encode(terminal_encoding, 'replace')). My guess is that it isn't writing
to self.outf like it should.

If it is happening at commit time, then I'm not sure what is up. I know we
changed little bits about commit, so it is possible that the commit reporting
code is no longer passing it to the write file descriptor.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGn+NTJdeBCYSNAAMRAsmyAJ4812ZUodHB7XsdEq1Siend/aawqwCgnXZ2
DoIX/7vOxXVN09n0yVhbAX4=
=/1Jz
-----END PGP SIGNATURE-----