[MERGE] Unit tests for win32 glob expansion

Alexander Belchenko bialix at ukr.net
Thu Jul 19 06:40:43 BST 2007


Alexander Belchenko has voted +1 (conditional).
Status is now: Conditionally approved
Comment:
=== modified file bzrlib/win32utils.py // 
last-changed:kuno.meyer at gmx.ch-200707
... 18201527-rn6j933vii35b6gm
--- bzrlib/win32utils.py
+++ bzrlib/win32utils.py
@@ -264,6 +264,7 @@
              expanded_file_list.append(possible_glob)
          else:
              expanded_file_list += glob_files
+    expanded_file_list = map(lambda x: x.replace('\\', '/'), 
expanded_file_list)
      return expanded_file_list

^-- I prefer use list comprehension, because map may go away in future 
versions of Python.
Also in this case we don't need to use lambda:

+    expanded_file_list = [x.replace('\\', '/') for x in 
expanded_file_list]

For details, see: 
http://bundlebuggy.aaronbentley.com/request/%3C469E8C4B.4050007%40gmx.ch%3E



More information about the bazaar mailing list