[MERGE] FileCollection

[Robert Collins]

On Wed, 2007-07-18 at 20:17 -0700, Martin Pool wrote:
> On 7/17/07, Robert Collins <robertc at robertcollins.net> wrote:
> > On Tue, 2007-07-17 at 11:11 +1000, Martin Pool wrote:
> > > Adding such a utility could be good.
> > >
> > > s/cand/can
> > >
> > > FileCollection is not a very obvious name.  ListingFile?  FileListing?
> >
> > NameList?
> >
> > Seems to me Names are the key thing.
> 
> Hm, OK.  "NameList" seems like it's just in memory.  NameIndexFile?
> NameListFile?
> 
> Naming of cats in a difficult matter...

ManagedNames? FileNames?

> > > It seems odd that it talks about sequence and stores them in sequence
> > > but returns them as a set, in random order.
> >
> > Oh, hmm. I'll rephrase that. I think this will need some tweaks shortly
> > to attach some minor metadata so that the repository code can setup the
> > index list in 'ideal' order - whatever that is...
> >
> > > It seems like excessive policy to allocate the names as integers
> > > within this file.  Why not let the caller supply them?
> >
> > Then the caller needs to ensure uniqueness. I have no use case for the
> > caller supplying the name
> 
> It does seem like a reasonably forseeable thing for them to do though.

I would rather supply a patch to do that when I have code that wants to
do it; theres plenty of other things to get right before then, and I
don't know what the api will need until I get there.

-Rob

-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070719/911c5633/attachment.pgp