[MERGE] FileCollection

[Martin Pool]

On 7/17/07, Robert Collins <robertc at robertcollins.net> wrote:
> On Tue, 2007-07-17 at 11:11 +1000, Martin Pool wrote:
> > Adding such a utility could be good.
> >
> > s/cand/can
> >
> > FileCollection is not a very obvious name.  ListingFile?  FileListing?
>
> NameList?
>
> Seems to me Names are the key thing.

Hm, OK.  "NameList" seems like it's just in memory.  NameIndexFile?
NameListFile?

Naming of cats in a difficult matter...

> > It seems odd that it talks about sequence and stores them in sequence
> > but returns them as a set, in random order.
>
> Oh, hmm. I'll rephrase that. I think this will need some tweaks shortly
> to attach some minor metadata so that the repository code can setup the
> index list in 'ideal' order - whatever that is...
>
> > It seems like excessive policy to allocate the names as integers
> > within this file.  Why not let the caller supply them?
>
> Then the caller needs to ensure uniqueness. I have no use case for the
> caller supplying the name

It does seem like a reasonably forseeable thing for them to do though.

-- 
Martin