[MERGE] FileCollection

Martin Pool mbp at sourcefrog.net
Tue Jul 17 02:11:24 BST 2007

Adding such a utility could be good.


FileCollection is not a very obvious name.  ListingFile?  FileListing?

It seems odd that it talks about sequence and stores them in sequence
but returns them as a set, in random order.

It seems like excessive policy to allocate the names as integers
within this file.  Why not let the caller supply them?

+    def iter_files_recursive(self):
+        Transport.iter_files_recursive(self)

I'd like a comment in those two methods explaining that the default
implementation raises an exception.

+    * New transport decorator 'unlistable+' which disables the list_dir
+      functionality for testing.

Take credit :)


More information about the bazaar mailing list