[MERGE] UTF-8 encoding in binary diffs

[Vincent Ladeuil]

>>>>> "mbp" == Martin Pool <mbp at sourcefrog.net> writes:

    mbp> On 7/6/07, Aaron Bentley <aaron.bentley at utoronto.ca> wrote:
    >> Aaron Bentley has voted +0.
    >> Status is now: Waiting
    >> Comment:
    >> Thanks.  I'm surprised your test case uses utf-8 for the filenames.
    >> That could conceivably break on non-utf8 filesystems.  Better to use
    >> unicode strings, I think.  But then you do need to make sure the test is
    >> skipped on non-unicode filesystems.

    mbp> Aaron is quite right, this does break if run with LANG=C, so it hasn't
    mbp> merged yet.

    mbp> (My vote before was meant to mean "this isn't totally right, but it's
    mbp> better than what we have now, so let's merge it.")

    mbp> Is there a standard way to skip tests that can't run because of the
    mbp> filesystem encoding? 

I'm not sure we can reliably determine filesystem encoding without
trying to create a file (think nfs mounts).

    mbp> I'm sure there must already be some but I can't see it.

I'm pretty sure there is none, jam may even have removed some
tests when he dropped OS X support attempts.

      Vincent