[MERGE] UTF-8 encoding in binary diffs
Martin Pool
mbp at sourcefrog.net
Wed Jul 11 10:10:30 BST 2007
On 7/6/07, Aaron Bentley <aaron.bentley at utoronto.ca> wrote:
> Aaron Bentley has voted +0.
> Status is now: Waiting
> Comment:
> Thanks. I'm surprised your test case uses utf-8 for the filenames.
> That could conceivably break on non-utf8 filesystems. Better to use
> unicode strings, I think. But then you do need to make sure the test is
> skipped on non-unicode filesystems.
Aaron is quite right, this does break if run with LANG=C, so it hasn't
merged yet.
(My vote before was meant to mean "this isn't totally right, but it's
better than what we have now, so let's merge it.")
Is there a standard way to skip tests that can't run because of the
filesystem encoding? I'm sure there must already be some but I can't
see it.
--
Martin
More information about the bazaar
mailing list