[MERGE] remove crackful MutableTree.smart_add behavior

[Robert Collins]

On Wed, 2007-07-04 at 14:27 -0400, Aaron Bentley wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Robert Collins wrote:
> > On Tue, 2007-07-03 at 21:56 -0400, Aaron Bentley wrote:
> >> My feeling was that ability to change the inventory without writing it
> >> to disk, and without intending to ever write it to disk was an
> >> unintentional feature, and not something to rely on.
> > 
> > We used to have add code that simulated adding the files, but it was
> > considerably more complicated. I think if we can keeping the current
> > constraint of allowing a revert-to-disk facility is better.
> 
> As it turns out, your code doesn't match the guarantee you have been
> fighting for.  This already-present test case proves it doesn't:


> Here's a patch to accomplish 3.

+1


-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070705/94454f99/attachment.pgp