'bzr rm' leaves directories behind?

Marius Kruger amanic at gmail.com
Mon Jun 25 18:49:21 BST 2007


I submitted a bundle incorporating your (Robert and Martins) requests.

On 6/22/07, Robert Collins <robertc at robertcollins.net> wrote:

> In particular : ("bzr rm file with spaces") cannot be correctly
> processed with a trivial string splitting helper inside the test suite.
> To avoid confusing readers - to optimise for folk reading the code - we
> should make it very clear when splitting is and is not happening. For
> these reasons we chose a couple of years back to make the recommended
> method be a list of strings, no magic involved.

I find it annoying to quote every single parameter for black box tests.
I think it should ALWAYS be splitting.
In the above case, the test should rather be
"bzr rm file\ with\ spaces" or
"bzr rm 'file with spaces'" or
'bzr rm "file with spaces"'
which my `run_bzr_captured` is catering for since it uses shlex,
this is constent with how it is used from the commandline.
My `run_bzr_captured` only splits if you give it a single string,
so it doesn't break existing tests.

Thats just what I think.

Because I don't trust Version Control Systems with less than 6350 unit
-------------- next part --------------
An HTML attachment was scrubbed...
URL: https://lists.ubuntu.com/archives/bazaar/attachments/20070625/a0270092/attachment.htm 

More information about the bazaar mailing list