Hi,<br><br>I submitted a bundle incorporating your (Robert and Martins) requests.<br><br><div><span class="gmail_quote">On 6/22/07, <b class="gmail_sendername">Robert Collins</b> <<a href="mailto:robertc@robertcollins.net">
robertc@robertcollins.net</a>> wrote:<br>...<br></span><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;">In particular : ("bzr rm file with spaces") cannot be correctly
<br>processed with a trivial string splitting helper inside the test suite.<br>To avoid confusing readers - to optimise for folk reading the code - we<br>should make it very clear when splitting is and is not happening. For
<br>these reasons we chose a couple of years back to make the recommended<br>method be a list of strings, no magic involved.</blockquote><div><br>I find it annoying to quote every single parameter for black box tests.<br>
I think it should ALWAYS be splitting.<br>In the above case, the test should rather be<br>"bzr rm file\ with\ spaces" or<br>"bzr rm 'file with spaces'" or<br>'bzr rm "file with spaces"'
<br>which my `run_bzr_captured` is catering for since it uses shlex,<br>this is constent with how it is used from the commandline.<br>My `run_bzr_captured` only splits if you give it a single string,<br>so it doesn't break existing tests.
<br><br>Thats just what I think.<br>regards<br>marius<br> <br></div></div><br>-- <br><a href="http://bazaar-vcs.org">bazaar-vcs.org</a><br>Because I don't trust Version Control Systems with less than 6350 unit tests.