[RFC] Deprecation warnings considered harmful

John Arbash Meinel john at arbash-meinel.com
Fri Jun 22 15:50:28 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool wrote:
> On 6/22/07, Robert Collins <robertc at robertcollins.net> wrote:
>> During a discussion with Aaron about the version compatability api I
>> proposed, he noted that one of the reasons for bzrtools strict
>> compatibility requirement is to avoid users complaining about
>> deprecation warnings when in fact its just that bzrtools needs an
>> upgrade.
>>
>> We could address this (as deprecations are meant to be compatible) by
>> disabling deprecations in the normal use of bzr from the command line.
>> External library users, and our test suite, will still benefit from them
>> - we'd want run_bzr to keep them enabled so that we catch them in tests.
> 
> That makes sense.  It should be just a one-line change to call into
> the warnings library and turn them off.
> 
> It would be nice if -Werror still had the usual effect though.  I do
> use that from time to time if trying to eliminate a warning.
> 

I think it could be good. I would certainly want a way to re-enable
them, so that I can see when deprecated functions are being called.
(AFAIK there are 1 or 2 untested cmd_* classes that are using deprecated
apis).

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGe+G0JdeBCYSNAAMRAgWpAJ92EWk74ayqTmPSJQk7gkL6jYxjPACfYlso
ct9oasfQDD5RbqajmKDZFnE=
=fSDb
-----END PGP SIGNATURE-----



More information about the bazaar mailing list