[MERGE] An SMTPConnection class for bzrlib

Adeodato Simó dato at net.com.org.es
Tue Jun 19 21:54:34 BST 2007


* John Arbash Meinel [Tue, 19 Jun 2007 16:29:14 -0400]:

> John Arbash Meinel has voted +1.
> Status is now: Semi-approved
> Comment:
> I won't argue about cleaner or not, but at this point, it has lost the main 
> advantage of the original SMTPConnection for me. Which is that I had a 
> single:

> send...(from, to, body, attachement) function, which I sorely miss from 
> python's smptlib.

> So I'm willing to accept something like this, but I would want at least a 
> wrapper that does all the setup. The *hard* part is putting together the 
> Email object with properly encoded headers and body. The *easy* part is 
> connecting and authenticating to a server.

> I'm fine with having these split out into multiple helper classes that 
> manage the separation of concern. (One for connecting, and one for building 
> an email). But I really do want/need the latter one.

> So overall, +1 from me, as a stepping stone to a complete solution.

Right, that was exactly my plan. I'm working at this moment on an
EmailMessage class based on the other part of the original SMTPConnection,
creating a message. It's API is simpler and clearer as well, I think
(that's obviously my opinion only :).

Cheers,

-- 
Adeodato Simó                                     dato at net.com.org.es
Debian Developer                                  adeodato at debian.org
 
Love in your heart wasn't put there to stay.
Love isn't love 'til you give it away.
                -- Oscar Hammerstein II




More information about the bazaar mailing list