REGRESSION in 0.17rc1, doing commit of files with unicode names.

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Ian Clatworthy wrote:
> Martin Pool wrote:
> 
>>> I like Aaron's idea of stopping note() logging to the file at all. Is
>>> that an acceptable approach to have product wide?
>> Do you mean to .bzr.log, or are you talking about the effect of --quiet?
>>
> I mean note() shouldn't write to .bzr.log.
> 
> Ian C.
> 
> 

One thing I should comment on. Which is that "note()" is actually incorrect for
this sort of logging.

Specifically, "note()" has been defined as "utf-8", but some consoles are not
UTF-8. Especially on Windows. Which is why we have done work to make
"Command.outf" a wrapper which takes Unicode and writes to stdout. We either
need to do something like that for stderr, fix the code to write to self.outf
instead of note/sys.stderr, or possibly also fix 'note()' to write utf-8 to the
log file, and console encoding to stderr.

I think there are even some bugs open about this.

Overall, I prefer to have Commit write to self.outf, rather than writing to
sys.stderr.

I would also be fine with '--quiet' being the default.

As far as logging to .bzr.log... It would be nice to have a function like
'note()' that you can alert the user about something, and have it logged
because you think it may be important.  However, we do have 'warning()', and I
think at this point, most of our note() calls are probably not critical anymore.

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGdpVWJdeBCYSNAAMRAglbAKCxIXG1VkoFxw9yjgdFcwDQJpng8QCfbeP0
zkdVKx/qHybI8F5MIvpqO8E=
=A7WV
-----END PGP SIGNATURE-----