[MERGE] revision-info fixes
John Arbash Meinel
john at arbash-meinel.com
Wed Jun 6 23:20:21 BST 2007
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Matthew D. Fuller wrote:
> On Wed, Jun 06, 2007 at 09:55:28AM -0400 I heard the voice of
> John Arbash Meinel, and lo! it spake thus:
>> Usually I'm of the mind that if we are opening a WT then we should
>> use open_containing() but if we are opening a branch we should use
>> .open()... but that doesn't really change things here.
>
> Well, I actually did that because I don't really know what I'm doing
> and it was a small change that seemed to work :)
>
> But looking at the docstrings, I think we _do_ want open_containing(),
> because open() sounds like it wants the root of the branch, and '.'
> may not actually be at the root when we run revision-info.
>
>
Which is why you would want open_containing() if it were a working tree, but
open() if it was a branch.
The command should probably be changed to be more consistent with other
commands, and take a location as the first argument, and use -r to specify a
revision. But it doesn't really matter.
John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (Darwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFGZzKpJdeBCYSNAAMRAqC7AJsFiQ34hpYGZGOlk1rG0y037uRBIACgsm7x
aU5MubIPNyO+2c0vOki6LwU=
=twed
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list