[MERGE] Conditionalize format warnings

[Robert Collins]

On Fri, 2007-05-25 at 09:49 -0400, Aaron Bentley wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Aaron Bentley wrote:
> > Aaron Bentley wrote:
> > 
> >> You can make base a required parameter of _check_supported, and issue a
> >> deprecation warning if it's not provided.
> > 
> > Actually, since it's internal, a warning isn't strictly necessary.
> > 
> > Oh, also: it looks like this is an infinite loop waiting to happen:
> > 
> > Branch.open => BzrDir.open_branch => BzrDir._check_supported => Branch.open
> 
> It's a bit different, but I wonder whether we should move the nag to
> (Tree|Branch|Repository).lock_write, after the lock succeeds?
> 
> That would prevent nags when we don't have write access, and mean that
> we could avoid double-opening branches.  Obviously, we'd need to ensure
> the nag only happened only once per invocation.

Since we aim to only open objects once per invocation for performance,
caching the nag-has-happened in the object would make sense to me.

Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070530/61541a07/attachment.pgp