[MERGE][bug #75721](0.17) "bzr push" should only connect 1 time

Martin Pool mbp at canonical.com
Wed May 2 02:30:14 BST 2007

Martin Pool has voted +1 (conditional).
Status is now: Conditionally approved

+    def _make_tail_on_transport(self, transport):
+        """Create the final directory in transport if it doesn't exist.
+        We use "Easier to ask for Permission". And just create it, and 
+        if the directory already exists.
+        """

I think this should be in Transport not here.
I think you mean "easier to seek forgiveness than permission".

Normally when we make new directories we need to be careful to use the 
right permissions, which is taken care of by LockableFiles.  (Not really 
a great place for it I think but that's a separate matter.)  I wonder if 
that can also be a problem here?  I think probably not, because we're 
starting a new repository and there's nothing it needs to be consistent 

OK with me for 0.16 if we move that method.

For details, see: 

More information about the bazaar mailing list