Why aliases in help on command shown on next line?

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Robert Collins wrote:
> On Mon, 2007-04-30 at 15:46 -0500, John Arbash Meinel wrote:
>> -----BEGIN PGP SIGNED MESSAGE-----
>> Hash: SHA1
>>
>> Alexander Belchenko wrote:
>>> 0.16rc1
>>>
>>> Is this intended change or regression?
>>> I'd like to see them on the same line as before.
>>>
>>> [µ]
>> I think it is a regression. Probably Robert's changes to the help
>> command code caused a regression for aliases.
>>
>> Specifically I think: (Line 277 in bzrlib/commands.py)
>>        if self.aliases:
>>             result += 'aliases:\n'
>>             result += ', '.join(self.aliases) + '\n'
>>
>> should be:
>>        if self.aliases:
>>             result += 'aliases: '
>>             result += ', '.join(self.aliases) + '\n'
> 
> Agreed. Sorry about this, I blame the relative lack of tests in this
> area :). +1 to merge that fix as is, with or without a test.
> 
> -Rob

Done, though I agree that we should have more direct tests of help
formatting. We haven't had that at all yet.

Probably we need a bzrlib/tests/test_help.py which can just test the
help formatter.

Or we should have a test in bzrlib/tests/test_commands.py for
Command.get_help_text()

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGNloeJdeBCYSNAAMRAowhAJ0ZjUOCwC24n2IrIkvdYmiuaeyUPQCfTPOk
n+W+E0Yf50kRK6+UkEi5oa4=
=MLDm
-----END PGP SIGNATURE-----