Why aliases in help on command shown on next line?

Robert Collins robertc at robertcollins.net
Mon Apr 30 21:59:10 BST 2007


On Mon, 2007-04-30 at 15:46 -0500, John Arbash Meinel wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
> 
> Alexander Belchenko wrote:
> > 0.16rc1
> >
> 
> > Is this intended change or regression?
> > I'd like to see them on the same line as before.
> > 
> > [µ]
> 
> I think it is a regression. Probably Robert's changes to the help
> command code caused a regression for aliases.
> 
> Specifically I think: (Line 277 in bzrlib/commands.py)
>        if self.aliases:
>             result += 'aliases:\n'
>             result += ', '.join(self.aliases) + '\n'
> 
> should be:
>        if self.aliases:
>             result += 'aliases: '
>             result += ', '.join(self.aliases) + '\n'

Agreed. Sorry about this, I blame the relative lack of tests in this
area :). +1 to merge that fix as is, with or without a test.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070501/a87330d4/attachment-0001.pgp 


More information about the bazaar mailing list