[MERGE] Hidden bug in `bzr info` when dirstate tree is write-locked

Alexander Belchenko bialix at ukr.net
Wed Apr 25 03:52:55 BST 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Martin Pool пишет:
> On 4/25/07, John Arbash Meinel <john at arbash-meinel.com> wrote:
>> Well, I updated the comment as we discussed on IRC.
>>
>> I personally feel that you should never raise "knownFailure()" without
>> actually checking that it fails.
>>
>> If only because if the underlying failure is ever fixed, you have no
>> idea what tests need to be updated (because they are all "passing").
> 
> Yes I know what you mean.
> 
> So maybe the api should actually be:
> 
>  def test_something():
>    # this isn't fully implemented yet
>    self.expectFailure()
>    self.assertEquals(1,2)

May be we can use decorator for such thing, i.e. something like

  @expectFailure
  def test_something():
    self.assertEquals(1,2)

or

  @expectFailureOnWin32
  def test_something():
    self.assertEquals(1,2)

Or unittest don't play well with decorated tests?

[µ]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGLsKHzYr338mxwCURAp9oAJ0ZeYKJPZMETOc5YiStBj3wjMqYAgCeIyxe
uc+hEPqcpxA3c+94/zHyFhg=
=H2Xv
-----END PGP SIGNATURE-----



More information about the bazaar mailing list