[MERGE] tags in log output

[Alexander Belchenko]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel пишет:
> John Arbash Meinel has voted +1 (conditional).
> Status is now: Conditionally approved
> Comment:
> The problem with "assertTrue(x in y)" is that when it fails, you don't
> have any debugging information. I think it would be better to use:
> 
> self.assertContainsRe(log, r'tags: (tag1, tag1\.1|tag1\.1, tag1)')
> 
> I also prefer "self.run_bzr()" over "self.runbzr()", though I'm not sure
> if that is an official line. At the very least, though, we shouldn't mix
> them.
> +        self.run_bzr('commit', '-m', 'foobar', '--unchanged')
> +        self.runbzr('tag tag1')
> 
> 
> Thanks for making "supports_tags" an attribute, rather than a function,
> but you need an extra blank line in:
>  class LongLogFormatter(LogFormatter):
> -    def show(self, revno, rev, delta):
> -        return self._show_helper(revno=revno, rev=rev, delta=delta)
> +    supports_tags = True    # must exist and be True
> 
> (we really should have a doc string, too)

Reworked patch. I think it worth to merge into 0.16,
because people ask about this feature,
and because it was conditionally approved before feature freeze.

Martin?

[µ]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGJ8M5zYr338mxwCURAtc7AJwMtHov8EBL2bJ5AFTupsR4hpRcJwCghWGi
BEFUkan9FZ5t9zvvgAP6J7Q=
=WB07
-----END PGP SIGNATURE-----
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: taglogs.v3.patch
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20070419/fd796505/attachment-0001.diff