[MERGE] tags in log output

John Arbash Meinel john at arbash-meinel.com
Thu Apr 12 15:23:28 BST 2007

John Arbash Meinel has voted +1 (conditional).
Status is now: Conditionally approved
The problem with "assertTrue(x in y)" is that when it fails, you don't 
have any debugging information. I think it would be better to use:

self.assertContainsRe(log, r'tags: (tag1, tag1\.1|tag1\.1, tag1)')

I also prefer "self.run_bzr()" over "self.runbzr()", though I'm not sure 
if that is an official line. At the very least, though, we shouldn't mix 
+        self.run_bzr('commit', '-m', 'foobar', '--unchanged')
+        self.runbzr('tag tag1')

Thanks for making "supports_tags" an attribute, rather than a function, 
but you need an extra blank line in:
  class LongLogFormatter(LogFormatter):
-    def show(self, revno, rev, delta):
-        return self._show_helper(revno=revno, rev=rev, delta=delta)
+    supports_tags = True    # must exist and be True

(we really should have a doc string, too)

For details, see: 

More information about the bazaar mailing list