[MERGE][BUG 51980] bzr log <file>returns inappropriate revisions

[Kent Gibson]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1



John Arbash Meinel wrote:
> Kent Gibson wrote:
>>
>>
>> I haven't had time yet to review your patch, but it sounds (overall)
>> good. I'll try to make some time to review the code changes. (Thanks for
>> all your effort, by the way)
>>
No problem.  Thanks for putting up with my bitching and whinging.

The changes could probably use some polish, and could certainly use a
more extensive test suite, but I think it's a big improvement over
what was there.
e.g. here are a few benchmarks for 'bzr log NEWS' on my machine:
    bzr.dev   ~1.5minutes
    your full delta approach ~7.5 minutes
    my patch ~10sec (and half of that is the time it takes to dump
~2000 entries to the screen)


>
> I know I'm a little out of the loop for '--long' format, because
> honestly I don't ever use it. I use:
> bzr log --short -r-10..-1 --forward
>
> as my default. Since it gives me about 1 screenful of just what I care
> about (what has been happening recently). And I can use the other when I
> need to dig in, but often I use either NEWS or annotate/viz for real
> digging.
>
> For example, if I want to know what release a bug was fixed in, NEWS is
> the easiest for that.
>
Fair enough.
Though I'm not thinking about it as applied to bzr.dev, but for other
projects that don't have a NEWS-like file.  Old habits die hard.

Cheers,
Kent.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFGHRFGgoxTFTi1P8QRAio+AJ9FjOEXMprP0WV8kKb7HCYocUjfewCg6P1R
/QgaR8IHlL0WGmtLDJ59u0w=
=MGYz
-----END PGP SIGNATURE-----