Test suite broken by strace in bzr.dev

[Ian Clatworthy]

Alexandr Belchenko wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Robert Collins пишет:
>   
>> On Fri, 2007-03-30 at 08:19 +0300, Olexandr Byelchenko wrote:
>>     
>>> Trivial fix to add import errno at the beginning of module:
>>>
>>> === modified file 'bzrlib/strace.py'
>>> --- bzrlib/strace.py    2007-03-27 07:37:12 +0000
>>> +++ bzrlib/strace.py    2007-03-30 01:00:31 +0000
>>> @@ -17,6 +17,7 @@
>>>
>>>  """Support for running strace against the current process."""
>>>
>>> +import errno
>>>  import os
>>>  import signal
>>>  import subprocess
>>>       
>> +1 - please commit this.
>>     
>
> Robert, I trying to commit this fix twice and twice get failure from PQM.
> My branch with fix here: http://bzrdev.bialix.com/trivial
>
> Bundle attached.
>
> Here the last failure error reports from PQM. Something wrong with PQM because it's every time
> chaotic error:
>
> ======================================================================
>
> ERROR: test_32_lock_wait_succeed (bzrlib.tests.test_lockdir.TestLockDir)
>
>
>
> vvvv[log from bzrlib.tests.test_lockdir.TestLockDir.test_32_lock_wait_succeed]
>
> contention on
> LockDir(file:///home/pqm/bzr-pqm-workdir/home/%2Btrunk/test0000.tmp/test_lockdir.TestLockDir.test_32_lock_wait_succeed/work/test_lock):
> Directory not empty:
> u'/home/pqm/bzr-pqm-workdir/home/+trunk/test0000.tmp/test_lockdir.TestLockDir.test_32_lock_wait_succeed/work/test_lock/pending.s878o10uj6l8ioes7n88.tmp':
> [Errno 39] Directory not empty
>
> last_info: None, new info: {'nonce': u'dyn7o83ti6qf67qsnvpr', 'start_time': u'1175466784',
> 'hostname': u'balleny', 'pid': u'1349', 'user': u'pqm at balleny'}
>
> contention on
> LockDir(file:///home/pqm/bzr-pqm-workdir/home/%2Btrunk/test0000.tmp/test_lockdir.TestLockDir.test_32_lock_wait_succeed/work/test_lock):
> Directory not empty:
> u'/home/pqm/bzr-pqm-workdir/home/+trunk/test0000.tmp/test_lockdir.TestLockDir.test_32_lock_wait_succeed/work/test_lock/pending.vstf5c0uoxrxniae91mr.tmp':
> [Errno 39] Directory not empty
>
> last_info: {'nonce': u'dyn7o83ti6qf67qsnvpr', 'start_time': u'1175466784', 'hostname': u'balleny',
> 'pid': u'1349', 'user': u'pqm at balleny'}, new info: {'nonce': u'dyn7o83ti6qf67qsnvpr', 'start_time':
> u'1175466784', 'hostname': u'balleny', 'pid': u'1349', 'user': u'pqm at balleny'}
>
> contention on
> LockDir(file:///home/pqm/bzr-pqm-workdir/home/%2Btrunk/test0000.tmp/test_lockdir.TestLockDir.test_32_lock_wait_succeed/work/test_lock):
> Directory not empty:
> u'/home/pqm/bzr-pqm-workdir/home/+trunk/test0000.tmp/test_lockdir.TestLockDir.test_32_lock_wait_succeed/work/test_lock/pending.bqrk3887zvz48b6y5t49.tmp':
> [Errno 39] Directory not empty
>
> last_info: {'nonce': u'dyn7o83ti6qf67qsnvpr', 'start_time': u'1175466784', 'hostname': u'balleny',
> 'pid': u'1349', 'user': u'pqm at balleny'}, new info: {'nonce': u'dyn7o83ti6qf67qsnvpr', 'start_time':
> u'1175466784', 'hostname': u'balleny', 'pid': u'1349', 'user': u'pqm at balleny'}
>
> contention on
> LockDir(file:///home/pqm/bzr-pqm-workdir/home/%2Btrunk/test0000.tmp/test_lockdir.TestLockDir.test_32_lock_wait_succeed/work/test_lock):
> Directory not empty:
> u'/home/pqm/bzr-pqm-workdir/home/+trunk/test0000.tmp/test_lockdir.TestLockDir.test_32_lock_wait_succeed/work/test_lock/pending.aiiefty4ftkb5ry24bxz.tmp':
> [Errno 39] Directory not empty
>
> last_info: {'nonce': u'dyn7o83ti6qf67qsnvpr', 'start_time': u'1175466784', 'hostname': u'balleny',
> 'pid': u'1349', 'user': u'pqm at balleny'}, new info: {'nonce': u'dyn7o83ti6qf67qsnvpr', 'start_time':
> u'1175466784', 'hostname': u'balleny', 'pid': u'1349', 'user': u'pqm at balleny'}
>
>
>
> ^^^^[log from bzrlib.tests.test_lockdir.TestLockDir.test_32_lock_wait_succeed]
>
> - ----------------------------------------------------------------------
>
> Traceback (most recent call last):
>
>   File "/home/pqm/bzr-pqm-workdir/home/+trunk/bzrlib/tests/test_lockdir.py", line 238, in
> test_32_lock_wait_succeed
>
>     lf2.wait_lock(timeout=0.4, poll=0.1)
>
>   File "/home/pqm/bzr-pqm-workdir/home/+trunk/bzrlib/lockdir.py", line 416, in wait_lock
>
>     raise LockContention(self)
>
> LockContention: Could not acquire lock
> LockDir(file:///home/pqm/bzr-pqm-workdir/home/%2Btrunk/test0000.tmp/test_lockdir.TestLockDir.test_32_lock_wait_succeed/work/test_lock)
>
>
>
> ======================================================================
>
> FAIL: test_strace_result_has_raw_log (bzrlib.tests.test_strace.TestStrace)
>
>
>
> vvvv[log from bzrlib.tests.test_strace.TestStrace.test_strace_result_has_raw_log]
>
>
>
> ^^^^[log from bzrlib.tests.test_strace.TestStrace.test_strace_result_has_raw_log]
>
> - ----------------------------------------------------------------------
>
> Traceback (most recent call last):
>
>   File "/home/pqm/bzr-pqm-workdir/home/+trunk/bzrlib/tests/test_strace.py", line 68, in
> test_strace_result_has_raw_log
>
>     self.assertContainsRe(result.raw_log, 'myfile')
>
>   File "/home/pqm/bzr-pqm-workdir/home/+trunk/bzrlib/tests/__init__.py", line 834, in assertContainsRe
>
>     raise AssertionError('pattern "%r" not found in "%r"'
>
> AssertionError: pattern "'myfile'" not found in "''"
>
>
>
> - ----------------------------------------------------------------------
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.6 (MingW32)
> Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
>
> iD8DBQFGEIukzYr338mxwCURAjJFAKCV8WvdfQoelkpmBtNzcctbXXnSVQCfYLb7
> RiMr+rt5FKzB/RdmhqLXW9o=
> =yzK9
> -----END PGP SIGNATURE-----
>   
> ------------------------------------------------------------------------
>
> # Bazaar revision bundle v0.9
> #
> # message:
> #   forgotten import
> # committer: Alexander Belchenko <bialix at ukr.net>
> # date: Sun 2007-04-01 23:45:17.280999899 +0300
>
> === modified file bzrlib/strace.py
> --- bzrlib/strace.py
> +++ bzrlib/strace.py
> @@ -17,6 +17,7 @@
>  
>  """Support for running strace against the current process."""
>  
> +import errno
>  import os
>  import signal
>  import subprocess
>
> === modified directory  // last-changed:bialix at ukr.net-20070401204517-xkdcexu9q
> ... fjntx13
> # revision id: bialix at ukr.net-20070401204517-xkdcexu9qfjntx13
> # sha1: 66b0849aca70e338b7f7fe5cb7e2417e33247c09
> # inventory sha1: ea5babce76b02f01ea4dd63c726b60406e232934
> # parent ids:
> #   pqm at pqm.ubuntu.com-20070401162926-2718905ae3092110
> # base id: pqm at pqm.ubuntu.com-20070401162926-2718905ae3092110
> # properties:
> #   branch-nick: trivial
>
>
>   
Alex,

I think test_strace.py needs the same import added.

Ian C.