[MERGE] Test suite overhaul from the hpss branch

[Robert Collins]

On Wed, 2007-03-28 at 16:57 -0400, John Arbash Meinel wrote:
> John Arbash Meinel has voted +1 (conditional).
> Status is now: Conditionally approved
> Comment:
> I think we could just set the default lock timeout to 0 for all tests, 
> except for ones that are explicitly testing lock timeouts. We could 
> possibly set it something small rather than 0.
> Alternatively, we could always have the lock timeout be 0, and instead 
> have the 'bzr' main script set it to 5 minutes.

Will do.

> 
> -        if not self.transport_server == MemoryServer:
> +        # NB: one HttpServer is taught to decorate properly,
> +        # this hack can be removed.
> +        if not self.vfs_transport_factory == MemoryServer:
>               self.transport_readonly_server = HttpServer
> 
> I think you mean 'once HttpServer is taught...'.
> It would be nice to have a bit more explanation. And what is 'NB' ? 
> (aNdrew Bennetts?)

Note bene.

> I'm not really sure about using tree.bzrdir.root_transport() to access 
> the "remote" working tree. Since we at least defined working trees as 
> being local only... Is this because you want to support MemoryTree?
> At least some explanation would be good.

Where is this? tree.bzrdir.root_transport() is always local [to the
tree], not remote - tree.branch.bzrdir.root_transport() could be remote.

-Rob
-- 
GPG key available at: <http://www.robertcollins.net/keys.txt>.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070329/0ce5f0b8/attachment-0001.pgp