[MERGE] apply_inventory_delta
Aaron Bentley
aaron.bentley at utoronto.ca
Tue Mar 27 14:01:53 BST 2007
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Martin Pool wrote:
> On 3/27/07, Aaron Bentley <aaron.bentley at utoronto.ca> wrote:
>> This patch implements MutableTree.apply_inventory_delta, which should
>> replace the need for WorkingTree._write_inventory. It was based on my
>> knowledge of TreeTransform's needs and Robert's knowledge of dirstate's
>> needs.
>
> That sounds good.
Cool. Do you have a review for this particular patch?
> Yes, I think add could do with a good scrub out; I may do it this
> week. What I had in mind basically is that there would be a core that
> generates a list of to-be-added files,
Don't forget the list of ignored files, too.
> and then we connect up various
> callbacks to that.
I think just returning the two lists might be enough.
> At the moment we have this strange 'reporter'
> thing which seems like it would almost be enough to set whether things
> are actually added or not.
IIRC, the "action" object used to control whether the operation was a
dry run or not.
Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org
iD8DBQFGCRXB0F+nu1YWqI0RAnoPAJ9rF/+i40mnNH1eUyknSPaccahpHQCdEdwq
l4kpFiYA2UhgKM53IjR4Vrc=
=uac5
-----END PGP SIGNATURE-----
More information about the bazaar
mailing list