[MERGE] hpss startup/shutdown hooks

Andrew Bennetts andrew at canonical.com
Mon Mar 26 06:47:14 BST 2007


Andrew Bennetts has voted +1 (conditional).
Status is now: Conditionally approved
Comment:
Slightly inconsistent indenting in NEWS.

 > +        """The server should close its listening socket when its 
stopped."""

"it's stopped"

+        # clean up the server and initial transport (which wont have 
connected)
+        server = self.server
+        # force a connection, which uses the listening socket to 
synchronise

The comments here perhaps need to be combined; the overlapping scope of 
the comments is quite confusing.

+        del transport

Be explicit about why the test does this.  It's not immediately clear 
why object lifetimes are relevant.

For details, see: 
http://bundlebuggy.aaronbentley.com/request/%3C1174815629.28932.5.camel%40localhost.localdomain%3E



More information about the bazaar mailing list