[merge]problems with committing merges in a dirstate tree with a symlink

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel wrote:

...

> 
> So I'm happy with the test_inv changes, but I think we need to have
> tearDown run for every test.

Oh, and if possible this should be factored out into separate tests,
rather than testing all the different behaviors in the same test. When
possible, small single-item tests are best.

something like


def test_skipped_setup(self):
  class SkippedSetupTest(unittest.TestCase):
    ...

  runner = ...
  test = SkippedSetupTest('test_skip')
  result = self.run_test_runner(runner, test)
  self.assertTrue(result.wasSuccessful())


def test_skipped_test(self):
  class SkippedTest(unittest.TestCase):
    ...

etc.


That makes it obvious what each test is testing. And reduces the bleed
over between tests. (Say we need to update something for one part, we
don't have to tweeze apart what code goes with which test).

John
=:->
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.5 (Cygwin)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFF9XXLJdeBCYSNAAMRAjSiAJ9Wb3+QhRDuM+wy7ITH8LlGLFtFVQCeNOaz
mGHikttPQOXCOVkm+nWAzXI=
=HrD/
-----END PGP SIGNATURE-----