[BUG] baz-import creating different inventory texts (ghosts? and corruption)

[John Arbash Meinel]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

I just came across a source of corruption for baz => bzr conversions.

It seems that a baz-import has been run 2 times. And in one case, it
decided that the last-changed revision for the files should be marked as
the ghost revision (--patch-200), and in the other case the last-changed
was '--base-0'.

The problem is that now the inventory texts differ, so if you create new
patches on top of one conversion, and then merge that into the other
conversion, you end up looking like the new patches are corrupt. Because
their sha1 sum doesn't match. (You can't apply the new delta on top of a
different base, and get the same text, obviously)

Just to clarify. I'm seeing 2 conversions of the same Arch repository
end up with different values for InventoryEntry.revision. I'm guessing
this is because baz-import changed, without changing the revision id
numbering.

Was this just a change in baz-import? On was it a change to the internal
bzrlib logic (such that ghosts could be considered a last-changed).

It could also be that one conversion had more history available than
another conversion. Certainly that is going to be a general problem.
Because the inventory files can differ drastically if one has fewer
ghosts than the other.

Essentially though, we can't really support ghosts as well as we think
we can. Unless we could somehow make 'InventoryEntry.revision' a loose
value. (Not include it in the checksum, etc)

John
=:->

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.3 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFF8bfCJdeBCYSNAAMRAr5DAJ9qD+Hyk+vilUJfRLKbbUZsA70fDQCgqEiF
SmLxX+JepOd1IaBo0pxauRE=
=/wuj
-----END PGP SIGNATURE-----