[MERGE] bzrlib.osutils fixes

[Aaron Bentley]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Dmitry Vasiliev wrote:
> Aaron Bentley wrote:
>> Dmitry Vasiliev wrote:
>>> John Arbash Meinel wrote:
>>>> I understand why tuple versus list doesn't matter,
>>
>> Also, Robert has some notes that tuples are 5x faster than lists.

>> So depending on how frequently this code is used, it might be more
>> efficient to do:

> I believe the code processes only 5 tuples at all at each 'bzr selftest'
> run so the fix just need to be as simple as possible

Sure.  I was just pointing out that, even when you can use tuples in
place of lists, it's not necessarily a good idea.  For all I knew, this
code could have been part of a dirstate inner loop.  Certainly we don't
want to optimize prematurely.

Aaron
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFF8X3c0F+nu1YWqI0RAunOAJ47IxVf4SREXecoI7oeOMc8iYdIhwCgiY+r
U5yDgHhx8rRSMqTXX1qB2g4=
=n2Tx
-----END PGP SIGNATURE-----