[MERGE] Support for Putty SSH implementation, 2-nd edition

Dmitry Vasiliev dima at hlabs.spb.ru
Tue Mar 6 12:14:33 GMT 2007


John Arbash Meinel wrote:
> Actually, you could use a Registry, since 'get(None)' is intended to 
> return the 'default'. Versus get('value') which could return a specific 
> vendor. And the default is key=None, so "Registry.get() is supposed to 
> return the default."
> 
> I'm not going to be strict on it, since you seem to have at least 
> conformed to a basic interface consistency with your implementation.

I've thought about it and now I think it's not so hard to implement 
since I'll need to return all whitespace back anyway. :-)

> I would like to ask you to revert your whitespace changes to errors.py 
> at least. Since that is already a likely place for text conflicts to 
> occur. (Which is a shame, since I'd really like to see them fixed :)

OK, then all whitespace changes will be in a separate patch. :-)

Isn't it will be too late for 0.15 if I'll send updated patch before 
Thursday?

-- 
Dmitry Vasiliev <dima at hlabs.spb.ru>
http://hlabs.spb.ru



More information about the bazaar mailing list