[MERGE] Support for Putty SSH implementation, 2-nd edition

Dmitry Vasiliev dima at hlabs.spb.ru
Tue Mar 6 11:36:17 GMT 2007


Andrew Bennetts wrote:
> Dmitry Vasiliev wrote:
>> Actually I just use Vim with trailing whitespace highlighting turned on 
>> (http://www.vim.org/scripts/script.php?script_id=790) and remove 
>> trailing whitespace by myself when appropriate or annoying. I think it's 
>> important (well at some point) for make code cleaner. Also trailing 
>> whitespace may prevent some Vi commands like '{' and '}' to work as 
>> expected. And there is even a note about trailing whitespace at the end 
>> of PEP-8.
> 
> It's not that removing trailing whitespace is inherently bad, it's that mixing
> cosmetic changes like that with other changes obscures the more interesting
> parts of the diff.  It also increases the chance that you'll get conflicts as
> other changes get merged into bzr.dev.  So in general it is best to restrict
> trailing whitespace changes to lines that you are touching anyway.

Yes, I understand that cosmetic changes may complicate patches review 
but it's need to be done anyway sooner or later.

> However, feel free to submit patches purely to cleanup whitespace!

Ok :-)

-- 
Dmitry Vasiliev <dima at hlabs.spb.ru>
http://hlabs.spb.ru



More information about the bazaar mailing list