[MERGE][0.15] Bugfix #82086: Searching location of CA bundle for PyCurl in env variable (CURL_CA_BUNDLE), and on win32 along the PATH

Alexander Belchenko bialix at ukr.net
Mon Feb 26 20:55:17 GMT 2007


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel пишет:
> Alexander Belchenko wrote:
>> John Arbash Meinel ?8H5B:
>>> John Arbash Meinel has voted +1 (conditional).
>>> Status is now: Conditionally approved
>>> Comment:
>>> I don't think it should search in cwd, since that is where people are
>>> writing code. It can be in the dir of 'bzr' or in the dir of 'bzrlib',
>>> but shouldn't ever look in '.'
>>> Otherwise, +1.
> 
> Remember the issues we've had when bzr accidentally imports code from
> the current working directory because of bugs in python's default path.
> 
> This is a similar issue. Your current working directory should not
> affect your ability to connect to https hosts.

New version. I make some check to exclude empty string from $PATH list.
Unfortunately, I cannot write test to ensure bzr cannot look in cwd,
because os.path.realpath('bzr') == os.path.join(os.getcwd(),'bzr')

- --
Alexander

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFF40fWzYr338mxwCURAmMBAKCOGOTcD0O28025hHR7bjSy9n4vegCfTwsB
hZ+d/qH8MikHbe6Hl4CiUL8=
=KJss
-----END PGP SIGNATURE-----
-------------- next part --------------
An embedded and charset-unspecified text was scrubbed...
Name: bugfix.82086.patch
Url: https://lists.ubuntu.com/archives/bazaar/attachments/20070226/18a67df3/attachment-0001.diff 


More information about the bazaar mailing list