PING: [was Re: [MERGE] bzr help transport [take 3.. or 4]]

Goffredo Baroncelli kreijack at tiscalinet.it
Wed Feb 7 22:12:42 GMT 2007


On Wednesday 07 February 2007, you (John Arbash Meinel) wrote:
> Goffredo Baroncelli wrote:
> > Is anyone still interested in this patch ?  I think I have addressed the 
> > principal concerns of Aaron & others: any comments ?
> > 
> > Goffredo
> 
> Sorry about the delay.  I think Robert had some valid concerns about
> considering http+pycurl an implementation detail (even though we suggest
> it to users from time to time). That 'readonly+' is probably not useful
> to include, etc.
> 
> At a code level, the main things that I see are PEP8 problems. I can
> clean it up, but it would be good for you to understand the basics so
> that we don't have to do as much of a cleanup in the future.

Ok, I cleaned-up the code as you suggest, I removed some protocol helps; 
moreover I added a little blackbox test case.

Enclosed the patch


Goffredo

-- 
gpg key@ keyserver.linux.it: Goffredo Baroncelli (ghigo) <kreijack at inwind.it>
Key fingerprint = CE3C 7E01 6782 30A3 5B87  87C0 BB86 505C 6B2A CFF9
-------------- next part --------------
A non-text attachment was scrubbed...
Name: bzr-transport-registry-help-topics.diff
Type: text/x-diff
Size: 127013 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070207/5ee74e4c/attachment-0001.bin 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
Url : https://lists.ubuntu.com/archives/bazaar/attachments/20070207/5ee74e4c/attachment-0001.pgp 


More information about the bazaar mailing list