[MERGE][0.14] Don't check plugins for tabs

[Alexander Belchenko]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

John Arbash Meinel пишет:
> Alexander Belchenko wrote:
>> John Arbash Meinel ?8H5B:
>>>> Etienne just posted this bug:
>>>> https://launchpad.net/bzr/+bug/80330
>>>>
>>>> And I noticed there are 2 bugs in selftest.
>>>>
>>>> 1) 'tools' only exists in the source tree
>>>> 2) test_source.py is checking if plugins have tabs characters in the
>>>> source. While I would recommend that they not avoid them, I don't think
>>>> we should have tests failing in those circumstances. Attached is a patch
>>>> which skips 'utils' and 'plugins', just like the copyright and gpl
>>>> license tests.
>>>>
>> something wrong with your patch -- it seems that diff contains also
>> fix for problems with annotate.
> 
> 
> 
> 
> Yeah, I was planning on removing that part, and I forget. Ignore it, and
> just focus on the following:
> 
>> === modified file 'bzrlib/tests/test_source.py'
>> --- bzrlib/tests/test_source.py	2006-11-06 21:00:45 +0000
>> +++ bzrlib/tests/test_source.py	2007-01-17 22:33:32 +0000
>> @@ -258,6 +258,8 @@
>>          incorrect = []
> 
>>          for fname, text in self.get_source_file_contents():
>> +            if '/util/' in fname or '/plugins/' in fname:
>> +                continue
>>              if '\t' in text:
>>                  incorrect.append(fname)
> 

It's looks very straightforward.
But what's about item 1?

- --
Alexander
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.6 (MingW32)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org

iD8DBQFFrrgKzYr338mxwCURAnF7AJ4lQs8xffMTOK0fJGisQURN/9cfewCghCfQ
VkBRra3MPl8vLfr9lh1tHhE=
=vJdt
-----END PGP SIGNATURE-----